Skip to content

Conversation

@thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Sep 25, 2024

TODO in follow-up PRs:

Done in this PR:

  • Update README.md to remove steps that were only meant for private preview
  • Migrate from alpha to beta

Our GitHub Actions CI will fail at the moment because we're not doing the FDC SDK generation. I will fix that in a follow-up PR Update: For now I just removed dataconnect from the CI build - tracking in #1672.

Copy link
Contributor

@marinacoelho marinacoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking very good! Just added some suggestions and some questions/points for us to discuss before merging.

@thatfiredev thatfiredev merged commit 984eefa into master Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants